-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add test steps and explicit support for Python 3.9 #578
Conversation
There seems to be a problem installing NiMARE in 3.9 and 3.10. Is it possible that our minimum version of |
Updating the version fixed the issue. Should we use the latest release ( |
If it still works for Python 3.6, then yes. Otherwise, I'd like to determine the most recent version that works for all Python versions we support. |
It seems like numpy has not released a wheel for Python 3.10. |
Darn... it seems like we'll have to wait until they release it. Would you rather add 3.9 support in this PR and tackle 3.10 later, or just wait to merge this? |
I would add 3.9 support in this PR and tackle 3.10 later. The numpy wheel may be out by next month, but any issues with a different package in 3.10 may delay the 3.9 support. |
That works for me. |
Can you do two things:
|
Thanks! 🤞 Here's hoping CI passes without issue. EDIT: And if it does I'll approve and merge. |
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 39 39
Lines 4267 4267
=======================================
Hits 3662 3662
Misses 605 605 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #575.
Changes proposed in this pull request: